My first controller is still going strong (as I haven't heard my brother complaining about having to buy a new one) and it came with a system that was bought the April after launch. My first spare broke when I threw it across the room (was playing Rare Replay and had an 8-year-old moment) and the replacement for that one is still doing well except the USB port is loose and most of the shittier USB cables I have for charging things on my PC don't have any plastic that connects to the controller which ends up torquing it. My fourth controller came with the Halo MCC edition system I bought at Halo 5's release and it's still OK but it spent quite some time upside down and has stick drift as a result (easily fixable but I just haven't). My Project Scorpio controller is part of a bad batch that came with that system and won't charge via the USB port nor will it retain a connection to my PC when plugged in. I didn't discover this until well after the warranty period so I'm stuck. It works perfectly if I use standard AAs or charge the pack with my Halo 5 edition controller and swap into the PS one.How long do they last, by the way? I've been using the Logitech F710, and it generally last a little more than 2 years - which is helped by the 3 year warranty. The Xbox One controller has only 3 *month* warranty though.
In short:
1 still going strong about 5 years later
1 broke due to user stupidity
1 has stick drift due to neglectful storage
1 has a borked USB port due to shitty cables
1 has a broke USB port due to manufacturing defect
I don't know if its worth starting over or not.