They don't infringe on any trademarks, any hardware patents have long since expired, and they don't use any copyrighted BIOS code from the original hardware, so they're perfectly legal clone machines.
Does it have real shoulder buttons too or just XY style? For some games like Mario Kart, F-Zero etc. real shoulder buttons are a must. Would be nice to have both for games that benefit from one or the other though.
It does have real shoulder buttons like on a GBA-SP. If you scroll through the pictures, they're visible in the picture of the device on its dock and in the next one. The buttons are also remappable.